Skip to content

Loading…

pathToRoot should be dynamic rather than static config #613

Merged
merged 1 commit into from

2 participants

@caridy

adding config addon into url to make sure that pathToRoot can be customized per context.

@caridy caridy adding config addon into url to make sure that pathToRoot can be cust…
…omized per context, and also allow Search addon to override url addon using the same namespace
cc90fc4
@caridy

@imalberto can u review this?

@imalberto
Yahoo Inc. member

NOTE: that now the url addon is reading the appConfig from the contextualized and not the static config anymore to address html5app that are built with a specific context.
+1

@caridy caridy merged commit 135ed5a into yahoo:develop-perf

1 check failed

Details default The Travis build failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 11, 2012
  1. @caridy

    adding config addon into url to make sure that pathToRoot can be cust…

    caridy committed
    …omized per context, and also allow Search addon to override url addon using the same namespace
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 1 deletion.
  1. +2 −1 lib/app/addons/ac/url.common.js
View
3 lib/app/addons/ac/url.common.js
@@ -40,7 +40,7 @@ YUI.add('mojito-url-addon', function(Y, NAME) {
function UrlAcAddon(command, adapter, ac) {
this.context = command.context;
this.rs = null;
- this.pathToRoot = ac.staticAppConfig.pathToRoot;
+ this.pathToRoot = ac.config.getAppConfig().pathToRoot;
this.maker = null;
}
@@ -142,6 +142,7 @@ YUI.add('mojito-url-addon', function(Y, NAME) {
}, '0.1.0', {requires: [
'querystring',
+ 'mojito-config-addon',
'mojito-route-maker',
'mojito-util'
]});
Something went wrong with that request. Please try again.