Add getter to avoid exposing _app for Manhattan use. #624

Merged
merged 1 commit into from Oct 12, 2012

Projects

None yet

2 participants

Contributor
mojit0 commented Oct 12, 2012

Avoids exposing _app to consumers who must give Express app object to Manhattan for deployment.

Contributor
mojit0 commented Oct 12, 2012

Adds a getter so that the server.js file for a Manhattan app can look like:

process.chdir(__dirname);

module.exports = function(config, token) {
var Mojito = require('mojito');
var app = Mojito.createServer();

process.emit("application-ready", token, app.getHttpServer());
};

Collaborator
caridy commented Oct 12, 2012

+1

@mojit0 should we cherry pick this for develop-perf for the pr2 as well?

Contributor
mojit0 commented Oct 12, 2012

Yea. It's likely needed in all branches.

@mojit0 mojit0 merged commit fe3a651 into yahoo:develop Oct 12, 2012

1 check was pending

default The Travis build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment