Move app init so any getHttpServer call returns initialized app instance... #625

Merged
merged 1 commit into from Oct 12, 2012

Projects

None yet

2 participants

@mojit0

The idea here is that some containers just want the app instance, but we were only initializing it if you called start(). This update moves the initialization into the getter to ensure the server instance you get is always initialized, but only initialized once.

@isao

+1

@isao

oh should you be returning here

return app.listen(...)

so it doesn't proceed to line 639/642?

@mojit0 mojit0 merged commit 0367e9e into yahoo:develop Oct 12, 2012

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment