support for moving YUI meta computation out of combo middleware #626

Merged
merged 4 commits into from Oct 15, 2012

Projects

None yet

2 participants

Member

No description provided.

Do we really want to do next here? If we have a url for the resource I think we should fail!

Owner

The documentation for connect is pretty thin, but in reading the code it appears that calling next(err) is a way to report a failure. That's what many of the middleware that come with connect do when they encounter an error. However, looking at how connect implements that it looks inefficient, so I'll add a custom 404 in this middleware.

(Technically it's a "403 forbidden", but for security reasons it's best not to expose the fact that files exist if they don't have the perms to be served.)

Why is this still commented out? This cache should work just fine.

Owner

I don't know, I didn't comment it out just preserved the fact that it was commented out. It looks like it was commented out at the time we initialized the git repo, so the fact that it is commented out is pretty old.

While I agree it's worth revisiting enabling this, I propose not to mix it in with the current YUI config work. (It seems wise to keep separate things separate.)

Collaborator
caridy commented Oct 15, 2012

Ok, let's fix the 404 and let's merge this.

@drewfish drewfish merged commit dfca9d8 into yahoo:develop-perf Oct 15, 2012

1 check failed

default The Travis build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment