fix bz 5904449 garbled console output on node 0.8+ #692

Merged
merged 1 commit into from Nov 5, 2012

Projects

None yet

2 participants

@isao
Contributor
isao commented Oct 31, 2012

if process.stdout is not a tty (i.e. a pipe) the
console.log interpreted the message as an object,
not a (colorized) string.

note: warn() & error() previously wrote to stdout,
now write to stderr.

cherry-picked from 3fd55c9 and b19c53f

Conflicts:
lib/management/utils.js

@isao
Contributor
isao commented Oct 31, 2012

on node 0.8.x

## before this commit
% mojito version | tail -3
path.existsSync is now called `fs.existsSync`.
  '11': 'n',
  '12': 'e',
  '13': '.' }

## after
% mojito version | tail -3
path.existsSync is now called `fs.existsSync`.
Version of mojito is 0.5.0pr2

✔ mojito done.
@isao
Contributor
isao commented Nov 1, 2012

btw Search needs this for 0.5.0, per @rwaldura. It's already landed on develop.

@isao isao fix bz 5904449 garbled console output on node 0.8+
if process.stdout is not a tty (i.e. a pipe) the
console.log interpreted the message as an object,
not a (colorized) string.

note: warn() & error() previously wrote to stdout,
now write to stderr.

cherry-picked from 3fd55c9

Conflicts:
	lib/management/utils.js
18b9079
@caridy
Collaborator
caridy commented Nov 5, 2012

+1

@isao isao merged commit 07ec30a into yahoo:develop-perf Nov 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment