Skip to content

fix mojito create -p option #831

Merged
merged 1 commit into from Dec 5, 2012

3 participants

@isao
isao commented Dec 4, 2012
  • add port: "{{port}}" to application.json
  • rename with .hb extension
@isao isao fix mojito create -p option
- add {{port}} to application.json
- rename with .hb extension
da79557
@caridy
caridy commented Dec 4, 2012

@isao we are transforming the port from a numeric value to a string, for some reason @drewfish change it to a numeric value, can you comment?

@isao
isao commented Dec 4, 2012

it was a trade-off to allow the raw json.hb file to be linted and syntax highlighted

@isao
isao commented Dec 4, 2012

note, this is not intended for pr6

@drewfish
Yahoo Inc. member
drewfish commented Dec 4, 2012

I changed the port numbers in tests/func/applications/apps.json which is a bit different.

@caridy
caridy commented Dec 4, 2012

+1 then

@isao isao merged commit 93741d7 into yahoo:develop Dec 5, 2012

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.