Skip to content

re-enable yaml support #916

Merged
merged 6 commits into from Jan 14, 2013

2 participants

@caridy
caridy commented Jan 11, 2013
  • continuation of issue #907 from @drewfish
  • closes #804
  • appConfig can be used as part of mojito start
  • comments are now supported
@caridy caridy referenced this pull request Jan 11, 2013
Closed

re-enable yaml support #907

@drewfish drewfish and 1 other commented on an outdated diff Jan 11, 2013
@@ -79,7 +83,14 @@ Store.createStore = function(options) {
appConfig: options.appConfig
});
- store.preload();
+ if ('initial' === options.preload) {
+ store.preloadInitial();
+ } else if ('skip' !== options.preload) {
+ // preload by default when the store is created, but
+ // if you only care about appConfig and package.json
+ // you probably should use 'skip' option.
@drewfish
Yahoo Inc. member
drewfish added a note Jan 11, 2013

This comment should be part of the method docs, not buried in the code.

@caridy
caridy added a note Jan 14, 2013

I will do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@drewfish
Yahoo Inc. member

+1

@caridy caridy merged commit c278416 into yahoo:develop Jan 14, 2013

1 check passed

Details default The Travis build passed
@caridy caridy deleted the caridy:yaml branch Jan 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.