Skip to content
Browse files

Closes OOZIE-119 relative path in coord dataset include should throw …

…exception if given
  • Loading branch information...
1 parent efc7c4a commit d831e88e2df5fcfadd76562ffe07724492e1738f Angelo Kaichen Huang committed with bansalmayank Jun 10, 2011
View
4 core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
@@ -880,6 +880,10 @@ protected String readDefinition(String appPath) throws CoordinatorJobException {
// app path could be a directory
Path path = new Path(uri.getPath());
+ // check file exists for dataset include file, app xml already checked
+ if (!fs.exists(path)) {
+ throw new URISyntaxException(path.toString(), "path not existed : " + path.toString());
+ }
if (!fs.isFile(path)) {
appDefPath = new Path(path, COORDINATOR_XML_FILE);
} else {
View
12 docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
@@ -1253,7 +1253,7 @@ a. Coordinator application definition that creates a coordinator action once a d
start="2009-01-01T24:00Z" end="2009-12-31T24:00Z" timezone="UTC"
xmlns="uri:oozie:coordinator:0.1">
<datasets>
- <include>datasets.xml</include>
+ <include>hdfs://foo:9000/app/dataset-definitions/datasets.xml</include>
</datasets>
<input-events>
<data-in name="input" dataset="logs">
@@ -1280,7 +1280,7 @@ b. Coordinator application definition that creates a coordinator action once an
start="2009-01-01T24:00Z" end="2009-12-31T24:00Z" timezone="UTC"
xmlns="uri:oozie:coordinator:0.1">
<datasets>
- <include>datasets.xml</include>
+ <include>hdfs://foo:9000/app/dataset-definitions/datasets.xml</include>
</datasets>
<input-events>
<data-in name="input" dataset="logs">
@@ -1329,7 +1329,7 @@ Coordinator application definition:
start="2009-01-01T24:00Z" end="2009-12-31T24:00Z" timezone="UTC"
xmlns="uri:oozie:coordinator:0.1">
<datasets>
- <include>datasets.xml</include>
+ <include>hdfs://foo:9000/app/dataset-definitions/datasets.xml</include>
</datasets>
<input-events>
<data-in name="input" dataset="logs">
@@ -1390,7 +1390,7 @@ Coordinator application definitions. A data-pipeline with two coordinator-applic
start="2009-01-01T01:00Z" end="2009-12-31T24:00Z" timezone="UTC"
xmlns="uri:oozie:coordinator:0.1">
<datasets>
- <include>datasets.xml</include>
+ <include>hdfs://foo:9000/app/dataset-definitions/datasets.xml</include>
</datasets>
<input-events>
<data-in name="input" dataset="15MinLogs">
@@ -1416,7 +1416,7 @@ Coordinator application definitions. A data-pipeline with two coordinator-applic
start="2009-01-01T24:00Z" end="2009-12-31T24:00Z" timezone="UTC"
xmlns="uri:oozie:coordinator:0.1">
<datasets>
- <include>datasets.xml</include>
+ <include>hdfs://foo:9000/app/dataset-definitions/datasets.xml</include>
</datasets>
<input-events>
<data-in name="input" dataset="1HourLogs">
@@ -1858,7 +1858,7 @@ Coordinator application definition:
start="2009-01-01T24:00Z" end="2009-12-31T24:00Z" timezone="UTC"
xmlns="uri:oozie:coordinator:0.1">
<datasets>
- <include>datasets.xml</include>
+ <include>hdfs://foo:9000/app/dataset-definitions/datasets.xml</include>
</datasets>
<input-events>
<data-in name="inputLogs" dataset="hourlyLogs">
View
1 release-log.txt
@@ -18,6 +18,7 @@ OOZIE-108 Upgrade pom version to 3.1.0.
-- Oozie 3.0.2 release
+OOZIE-119 relative path in coord dataset include should throw exception if given
OOZIE-115 oozie should check if app path is directory and read the app xml under it
-- Oozie 3.0.1 release

0 comments on commit d831e88

Please sign in to comment.
Something went wrong with that request. Please try again.