Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vendored Zookeeper libs #51

Merged
merged 4 commits into from Jun 10, 2019

Conversation

Projects
None yet
3 participants
@varunvarma
Copy link
Contributor

commented Jun 10, 2019

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

  • Remove step to download and install Zookeeper, thus removing an external dependency
  • Remove platform-specific steps in tox since the vendored Zookeeper has the same paths on Linux and Mac OS X. This might have to be re-introduced at a later date if platform-specific changes emerge again
@coveralls

This comment has been minimized.

Copy link

commented Jun 10, 2019

Pull Request Test Coverage Report for Build 206

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 75.953%

Totals Coverage Status
Change from base Build 201: 0.07%
Covered Lines: 3367
Relevant Lines: 4433

💛 - Coveralls

@ilholmes ilholmes merged commit afb4ad6 into yahoo:master Jun 10, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.07%) to 75.953%
Details

@varunvarma varunvarma deleted the varunvarma:vendored_zookeeper branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.