Add proper module api for node users #619

Merged
merged 1 commit into from Dec 20, 2016

Projects

None yet

3 participants

@redonkulus
Contributor
redonkulus commented Dec 20, 2016 edited

@bugeats @ericf

Fixes #565

This add a simple API to get the path to a css file and also its contents.

One caveat here is that I changed main from exporting the build/pure-min.css to exporting index.js. Its technically a breaking change, but the previous behavior would fail because node cannot require a css file. I added the browser property back to the original file in case someone is bundling this package for the client.

@redonkulus redonkulus add proper module api for node users
cd6364f
@yahoocla

CLA is valid!

@bugeats
bugeats commented Dec 20, 2016

Looks great, thanks! Tests even! 👍

@redonkulus redonkulus merged commit 14c7ef9 into master Dec 20, 2016

3 checks passed

cla/licenses User has a valid Yahoo CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@redonkulus redonkulus deleted the module branch Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment