Skip to content

Fix bug : Rectangle badge sticks out when using bordar Radius and gradient - #59

Merged
yadaniyil merged 1 commit into
yako-dev:masterfrom
Umigishi-Aoi:fix-bug-that-Rectangle-sticks-out-when-using-bordarRadius-and-gradient
Jun 2, 2022
Merged

Fix bug : Rectangle badge sticks out when using bordar Radius and gradient#59
yadaniyil merged 1 commit into
yako-dev:masterfrom
Umigishi-Aoi:fix-bug-that-Rectangle-sticks-out-when-using-bordarRadius-and-gradient

Conversation

@Umigishi-Aoi

Copy link
Copy Markdown
Contributor

Description

Rectangle badge sticks out when using bordar Radius and gradient.

スクリーンショット 2022-03-11 16 01 11

code

Badge(
  badgeContent: const Text('New'),
  child: const Icon(
    Icons.mail,
    color: Colors.black,
    size:50,
  ),
  gradient: const LinearGradient(colors:[ Colors.blue,Colors.red]),
  shape: BadgeShape.square,
  borderRadius: BorderRadius.circular(10),
  borderSide: const BorderSide(width: 3),
),

So, I fix it.

I added borderRadius in BoxDecoration in _badgeViewGradient() in lib/src/badge.dart.

After code modification
スクリーンショット 2022-03-11 16 43 24

Please confirm this changes.

Thank you.

@Umigishi-Aoi

Copy link
Copy Markdown
Contributor Author

Sorry,I didn't know that you are in Ukraine.

This pull request should be postponed.
Please live anyway.

I pray for your safety.

@yadaniyil

Copy link
Copy Markdown
Collaborator

Hey @Umigishi-Aoi. Thanks for your PR, it's really useful. Also, thanks for the caring, we will win!

@yadaniyil
yadaniyil merged commit 84e66bb into yako-dev:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants