Permalink
Browse files

temporarily disable principality warning test in coercion.ml

Contrarily to the previous commit, this change is *not* completely
benine: it corresponds to the fact that Jacques' trunk@14523 (a
principality warning on formats in some situation) has not yet been
replayed on the format-gadts branch -- I mainly focused on backward
compatiblity.

The plan is to replay this change really soon, *after* converting
format6 to a nominal datatype -- this will much simplify the
re-implementation of the warning in the type-checker.

git-svn-id: http://caml.inria.fr/svn/ocaml/trunk@14847 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
  • Loading branch information...
1 parent af49756 commit ac23816f4afefdf248210d00d7178c4a569e355b @gasche gasche committed May 12, 2014
Showing with 4 additions and 6 deletions.
  1. +4 −6 testsuite/tests/typing-warnings/coercions.ml.principal.reference
@@ -1,13 +1,11 @@
-# Characters 76-79:
- fun b -> if b then format_of_string "x" else "y";;
- ^^^
-Warning 18: this coercion to format6 is not principal.
-- : bool -> ('a, 'b, 'c, 'd, 'd, 'a) format6 = <fun>
+# - : bool -> ('a, 'b, 'c, 'd, 'd, 'a) format6 = <fun>
# Characters 28-48:
fun b -> if b then "x" else format_of_string "y";;
^^^^^^^^^^^^^^^^^^^^
-Error: This expression has type ('a, 'b, 'c, 'd, 'd, 'a) format6
+Error: This expression has type
+ ('a, 'b, 'c, 'd, 'd, 'a) format6 =
+ ('a, 'b, 'c, 'd, 'd, 'a) CamlinternalFormatBasics.fmt * string
but an expression was expected of type string
# - : bool -> ('a, 'b, 'a) format = <fun>
#

0 comments on commit ac23816

Please sign in to comment.