New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libyaml allows illegal single-quote escape #68

Closed
headius opened this Issue Nov 29, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@headius

headius commented Nov 29, 2017

libyaml appears to allow a single-quote escape sequence that is NOT allowed by YAML 1.1+.

From the spec, at http://yaml.org/spec/1.1/#id872840, you can see that double quote is a valid escape but single quote is not.

This has been reported as a JRuby bug multiple times because MRI (C Ruby) uses libyaml for its YAML engine. See jruby/jruby#2199, jruby/jruby#4847, and https://bugs.ruby-lang.org/issues/14096.

At this time, neither we nor the YAML library we use (SnakeYAML) plan to support this illegal character. I think it would be best for all YAML consumers if libyaml stuck to the spec here.

perlpunk added a commit that referenced this issue Nov 29, 2017

perlpunk added a commit that referenced this issue Nov 29, 2017

perlpunk added a commit that referenced this issue Dec 1, 2017

@perlpunk

This comment has been minimized.

Show comment
Hide comment
@perlpunk

perlpunk Dec 1, 2017

Member

Created PR #74

Member

perlpunk commented Dec 1, 2017

Created PR #74

perlpunk added a commit that referenced this issue Dec 2, 2017

@perlpunk

This comment has been minimized.

Show comment
Hide comment
@perlpunk

perlpunk Dec 23, 2017

Member

PR #74 merged

Member

perlpunk commented Dec 23, 2017

PR #74 merged

@ingydotnet

This comment has been minimized.

Show comment
Hide comment
@ingydotnet

ingydotnet Jan 8, 2018

Member

@perlpunk This should be closed now, right? Closing...

Member

ingydotnet commented Jan 8, 2018

@perlpunk This should be closed now, right? Closing...

@ingydotnet ingydotnet closed this Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment