Skip to content

Removed Python 2.6 & 3.3#105

Merged
nitzmahone merged 11 commits into
yaml:masterfrom
engnadeau:patch-1
Feb 24, 2019
Merged

Removed Python 2.6 & 3.3#105
nitzmahone merged 11 commits into
yaml:masterfrom
engnadeau:patch-1

Conversation

@engnadeau

@engnadeau engnadeau commented Dec 3, 2017

Copy link
Copy Markdown

DEPRECATION: Python 2.6 is no longer supported by the Python core team

@hugovk hugovk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@engnadeau

Copy link
Copy Markdown
Author

@hugovk thanks for the reminder! Travis passes now

@engnadeau

Copy link
Copy Markdown
Author

@alex @dstufft @hugovk is there anything else you'd like me to look into?

@hugovk hugovk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

It would be good to add this to setup() in setup.py, so pip will install the correct distribution for the user's Python version:

python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*',

@engnadeau engnadeau changed the title Removed Python 2.6 Removed Python 2.6 & 3.3 Dec 8, 2017
@alex

alex commented Dec 8, 2017

Copy link
Copy Markdown
Contributor

I'd encourage the PyYAML maintainers to land this in a separate release from the current master. That is because master includes making PyYAML safe by default, and I don't want that to be denied to people who are (depressingly) insistent on using 2.6.

@engnadeau

engnadeau commented Dec 8, 2017

Copy link
Copy Markdown
Author

@hugovk following your python_requires suggestion, I also noted that Py3.3 is EoL as well. The following commits also clean this up:

However, if you prefer, I can move this into its own PR

@alex, Python 2.6 builds are not passing on master...

@alex

alex commented Dec 9, 2017

Copy link
Copy Markdown
Contributor

They're failing because we install a version of wheel that's too new. I'm not saying this is good, I'd be very happy for Python 2.6 to die a firey death, but given the choice between YAML RCEs and Python2.6 fixes, I want everyone to get the RCE fixes.

@hugovk

hugovk commented Dec 9, 2017

Copy link
Copy Markdown
Contributor

As a compromise, how about making a release quite soon with the RCE fixes, then merging this right after release?

@alex

alex commented Dec 9, 2017

Copy link
Copy Markdown
Contributor

That sounds great to me. To the PyYAML maintainers: if there's anything I can do to help get a release out, please let me know!

@engnadeau

Copy link
Copy Markdown
Author

@hugovk is there an open issue for YAML RCEs that we can link this PR to?

@hugovk

hugovk commented Dec 10, 2017

Copy link
Copy Markdown
Contributor

Let's ask @alex.

@alex

alex commented Dec 10, 2017

Copy link
Copy Markdown
Contributor

#74

@engnadeau

Copy link
Copy Markdown
Author

Happy New Year @alex @hugovk @jdufresne !

What's the status of this PR?

@hugovk

hugovk commented Jan 5, 2018

Copy link
Copy Markdown
Contributor

Looks good to me, but I don't think any of us three can merge.

@engnadeau

Copy link
Copy Markdown
Author

Ahh! @sigmavirus24 is the merger :)

@gdubicki

Copy link
Copy Markdown

Python 2.6 tests are blocking #143 , which I care about. Can you please take a look at this MR, @sigmavirus24 ? Or otherwise perhaps share your permission with people who have more time for this project? Thanks in advance! :)

@perlpunk

Copy link
Copy Markdown
Member

@gdubicki I believe tests for #143 were failing because of some travis + 2.6 issue. I just rebased my PR to master and force-pushed. 2.6 is passing now, waiting for 3.7-dev

@dstufft

dstufft commented Jun 28, 2018

Copy link
Copy Markdown
Contributor

Also modern versions of pip can ignore versions of a library that don't work for a specific version of Python if said project sets metadata correctly. 2.6 users are going to increasingly run into issues where libraries don't work on 2.6 anymore (particularly since pip itself no longer supports it), and are likely going to want to upgrade to a version of pip with that mechanism just for their own sanity sake.

@cclauss

cclauss commented Feb 24, 2019

Copy link
Copy Markdown
Contributor

Perfect timing... 20 days until Python 3.4 end of life.

print((date(2019, 3, 16) - date.today()).days, 'days until Python 3.4 end of life.')

https://devguide.python.org/index?#status-of-python-branches

nitzmahone added a commit that referenced this pull request Feb 24, 2019
ingydotnet pushed a commit that referenced this pull request Feb 25, 2019
ingydotnet pushed a commit that referenced this pull request Feb 25, 2019
@engnadeau engnadeau deleted the patch-1 branch February 25, 2019 17:49
ingydotnet pushed a commit that referenced this pull request Feb 26, 2019
ingydotnet pushed a commit that referenced this pull request Feb 28, 2019
ingydotnet pushed a commit that referenced this pull request Mar 7, 2019
ingydotnet pushed a commit that referenced this pull request Mar 8, 2019
ingydotnet pushed a commit that referenced this pull request Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.