Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Python 2.6 & 3.3 #105

Merged
merged 11 commits into from Feb 24, 2019
Merged

Removed Python 2.6 & 3.3 #105

merged 11 commits into from Feb 24, 2019

Conversation

@nnadeau
Copy link
Contributor

@nnadeau nnadeau commented Dec 3, 2017

DEPRECATION: Python 2.6 is no longer supported by the Python core team
Copy link
Contributor

@hugovk hugovk left a comment

Loading

@nnadeau
Copy link
Contributor Author

@nnadeau nnadeau commented Dec 4, 2017

@hugovk thanks for the reminder! Travis passes now

Loading

@nnadeau
Copy link
Contributor Author

@nnadeau nnadeau commented Dec 6, 2017

@alex @dstufft @hugovk is there anything else you'd like me to look into?

Loading

hugovk
hugovk approved these changes Dec 8, 2017
Copy link
Contributor

@hugovk hugovk left a comment

Looks good.

It would be good to add this to setup() in setup.py, so pip will install the correct distribution for the user's Python version:

python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*',

Loading

@nnadeau nnadeau changed the title Removed Python 2.6 Removed Python 2.6 & 3.3 Dec 8, 2017
@alex
Copy link
Contributor

@alex alex commented Dec 8, 2017

I'd encourage the PyYAML maintainers to land this in a separate release from the current master. That is because master includes making PyYAML safe by default, and I don't want that to be denied to people who are (depressingly) insistent on using 2.6.

Loading

@nnadeau
Copy link
Contributor Author

@nnadeau nnadeau commented Dec 8, 2017

@hugovk following your python_requires suggestion, I also noted that Py3.3 is EoL as well. The following commits also clean this up:

However, if you prefer, I can move this into its own PR

@alex, Python 2.6 builds are not passing on master...

Loading

@alex
Copy link
Contributor

@alex alex commented Dec 9, 2017

They're failing because we install a version of wheel that's too new. I'm not saying this is good, I'd be very happy for Python 2.6 to die a firey death, but given the choice between YAML RCEs and Python2.6 fixes, I want everyone to get the RCE fixes.

Loading

@hugovk
Copy link
Contributor

@hugovk hugovk commented Dec 9, 2017

As a compromise, how about making a release quite soon with the RCE fixes, then merging this right after release?

Loading

@alex
Copy link
Contributor

@alex alex commented Dec 9, 2017

That sounds great to me. To the PyYAML maintainers: if there's anything I can do to help get a release out, please let me know!

Loading

@nnadeau
Copy link
Contributor Author

@nnadeau nnadeau commented Dec 10, 2017

@hugovk is there an open issue for YAML RCEs that we can link this PR to?

Loading

@hugovk
Copy link
Contributor

@hugovk hugovk commented Dec 10, 2017

Let's ask @alex.

Loading

@alex
Copy link
Contributor

@alex alex commented Dec 10, 2017

#74

Loading

@nnadeau
Copy link
Contributor Author

@nnadeau nnadeau commented Jan 5, 2018

Happy New Year @alex @hugovk @jdufresne !

What's the status of this PR?

Loading

@hugovk
Copy link
Contributor

@hugovk hugovk commented Jan 5, 2018

Looks good to me, but I don't think any of us three can merge.

Loading

@nnadeau
Copy link
Contributor Author

@nnadeau nnadeau commented Jan 5, 2018

Ahh! @sigmavirus24 is the merger :)

Loading

@gdubicki
Copy link

@gdubicki gdubicki commented Apr 15, 2018

Python 2.6 tests are blocking #143 , which I care about. Can you please take a look at this MR, @sigmavirus24 ? Or otherwise perhaps share your permission with people who have more time for this project? Thanks in advance! :)

Loading

@perlpunk
Copy link
Member

@perlpunk perlpunk commented Apr 15, 2018

@gdubicki I believe tests for #143 were failing because of some travis + 2.6 issue. I just rebased my PR to master and force-pushed. 2.6 is passing now, waiting for 3.7-dev

Loading

@cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 24, 2019

Perfect timing... 20 days until Python 3.4 end of life.

print((date(2019, 3, 16) - date.today()).days, 'days until Python 3.4 end of life.')

https://devguide.python.org/index?#status-of-python-branches

Loading

nitzmahone added a commit that referenced this issue Feb 24, 2019
@ingydotnet ingydotnet moved this from Possible PRs and To Do items to Added to release/5/1 branch in 5.1 Release Feb 24, 2019
ingydotnet added a commit that referenced this issue Feb 25, 2019
ingydotnet added a commit that referenced this issue Feb 25, 2019
@nnadeau nnadeau deleted the patch-1 branch Feb 25, 2019
ingydotnet added a commit that referenced this issue Feb 26, 2019
ingydotnet added a commit that referenced this issue Feb 28, 2019
ingydotnet added a commit that referenced this issue Mar 7, 2019
ingydotnet added a commit that referenced this issue Mar 8, 2019
ingydotnet added a commit that referenced this issue Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.1 Release
Added to release/5/1 branch
Linked issues

Successfully merging this pull request may close these issues.

None yet