Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topK and topKWeighted now supports custom loadFactor #4634

Merged
merged 3 commits into from Mar 11, 2019

Conversation

Projects
None yet
2 participants
@kirillDanshin
Copy link
Contributor

kirillDanshin commented Mar 9, 2019

Signed-off-by: Kirill Danshin kirill@danshin.pro

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Improvement

Short description (up to few sentences):
topK and topKWeighted now supports custom loadFactor (fixes #4252)

topK and topKWeighted now supports custom loadFactor
Signed-off-by: Kirill Danshin <kirill@danshin.pro>
@kirillDanshin

This comment has been minimized.

Copy link
Contributor Author

kirillDanshin commented Mar 10, 2019

@alexey-milovidov not sure if stateless tests failed due to this change

alexey-milovidov added a commit that referenced this pull request Mar 10, 2019

alexey-milovidov added some commits Mar 10, 2019

@alexey-milovidov

This comment has been minimized.

Copy link
Member

alexey-milovidov commented Mar 10, 2019

@kirillDanshin It's unrelated: ac4045c

@alexey-milovidov alexey-milovidov self-requested a review Mar 10, 2019

alexey-milovidov added a commit that referenced this pull request Mar 11, 2019

Merge pull request #4643 from yandex/topk-fix-ub
Fixed UB in topKWeighted aggregate function #4634

@alexey-milovidov alexey-milovidov merged commit edaceba into yandex:master Mar 11, 2019

17 of 18 checks passed

Marker check Check of PR is started
ClickHouse build check 10/10 builds are OK
Details
Compatiblity check Compatiblity check passed
Details
Functional stateful tests (address) fail:0, passed:93
Details
Functional stateful tests (debug) fail:0, passed:93
Details
Functional stateful tests (release) fail:0, passed:93
Details
Functional stateful tests (ubsan) fail:0, passed:93
Details
Functional stateless tests (address) fail:0, passed:1066, skipped:1
Details
Functional stateless tests (debug) fail:0, passed:1066, skipped:1
Details
Functional stateless tests (release) fail:0, passed:1067
Details
Functional stateless tests (ubsan) fail:0, passed:1065, skipped:2
Details
Functional stateless tests (unbundled) fail:0, passed:1059, skipped:8
Details
Integration tests (asan) failed:0, passed:121, error:0
Details
Integration tests (release) failed:0, passed:121, error:0
Details
PVS check Found 64 errors and 78 warnings
Details
Performance test 914/915 queries are OK
Details
Stress test No errors found
Details
Style check Style check passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.