Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLICKHOUSE-4523 Fix "Column '0' already exists" in SELECT .. PREWHERE on column with DEFAULT #5397

Merged
merged 5 commits into from May 25, 2019

Conversation

proller
Copy link
Contributor

@proller proller commented May 23, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Bug Fix

Short description (up to few sentences):
Fix "Column '0' already exists" in SELECT .. PREWHERE on column with DEFAULT

@alexey-milovidov alexey-milovidov added the pr-bugfix Pull request with bugfix, not backported by default label May 25, 2019
{
if (std::find(required_source_columns.begin(), required_source_columns.end(), delete_column.name) == required_source_columns.end())
{
copy_block.erase(delete_column.name);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Five whitespaces!

@alexey-milovidov alexey-milovidov merged commit 6c1cb02 into ClickHouse:master May 25, 2019
akuzm pushed a commit that referenced this pull request May 29, 2019
… on column with DEFAULT (#5397)

* CLICKHOUSE-4523 Fix "Column '0' already exists" in SELECT .. PREWHERE on column with DEFAULT

* fix style

* Fix build

* Update iostream_debug_helpers.cpp

* Update evaluateMissingDefaults.cpp

(cherry picked from commit 6c1cb02)
akuzm added a commit that referenced this pull request May 31, 2019
…SELECT .. PREWHERE… (#5467)

* CLICKHOUSE-4523 Fix "Column '0' already exists" in SELECT .. PREWHERE on column with DEFAULT (#5397)

* CLICKHOUSE-4523 Fix "Column '0' already exists" in SELECT .. PREWHERE on column with DEFAULT

* fix style

* Fix build

* Update iostream_debug_helpers.cpp

* Update evaluateMissingDefaults.cpp

(cherry picked from commit 6c1cb02)

* Update evaluateMissingDefaults.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants