Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed boost::filesystem to std::filesystem #6253

Merged
merged 1 commit into from Aug 1, 2019

Conversation

alexey-milovidov
Copy link
Member

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Build/Testing/Packaging Improvement

Short description (up to few sentences):
Switched from boost::filesystem to std::filesystem where appropriate.

@alexey-milovidov alexey-milovidov added the pr-build Pull request with build/testing/packaging improvement label Jul 31, 2019
@alexey-milovidov alexey-milovidov merged commit e8cac8a into master Aug 1, 2019
@hczhcz
Copy link
Contributor

hczhcz commented Aug 1, 2019

It breaks the default cmake settings on my computer (linuxmint 19, with g++ & libstdc++) since they have not moved <experimental/filesystem> to <filesystem> yet.

For now, -DUSE_LIBCXX=1 -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants