Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with translucent activities on Pixel devices #5

Closed
wants to merge 1 commit into from

Conversation

@sirekanyan
Copy link

commented May 31, 2019

This PR should fix issue #4

@sirekanyan sirekanyan changed the title Remove finishRunnable to fix issue yandex-login-sdk-android#4 Fix problem with translucent activities on Pixel devices May 31, 2019

@HotIceCream

This comment has been minimized.

Copy link

commented May 31, 2019

This activity should work in two cases: with don't keep activities and without. Also, it should be closed if the user presses the back button.

Workaround with the handler and removing callback in onResume should solve these cases. Removing it broke one of them.

@HotIceCream

This comment has been minimized.

Copy link

commented May 31, 2019

After opening a browser from BrowserLoginActivity it shouldn't finish. It should be still in Activity task and save it state. BrowserDataActivity receives redirect in the browser and recalls BrowserLoginActivity for restoring it and drop browser in Activity task. Then BrowserLoginActivity completes authorization and sends the result to application in setResult().

@sirekanyan

This comment has been minimized.

Copy link
Author

commented May 31, 2019

Frankly, I haven't tested this fix thoroughly because of we already use sdk 2.1.1, and don't want to move back to 2.1.0. It would be nice if you could publish sources for 2.1.1 (see issue #3).

As I understand, we need behavior like FLAG_ACTIVITY_FORWARD_RESULT provides. To be able to pass result directly from the third activity to the first one (skipping the second activity).

But it seems if we start a browser we can't do that.

@sirekanyan

This comment has been minimized.

Copy link
Author

commented May 31, 2019

Thanks for publishing 2.1.1
The fix breaks behavior. PR should be declined :/

@sirekanyan sirekanyan closed this May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.