added offset option. #1

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@digi604

digi604 commented Feb 7, 2012

We have a stl that had an offset and we needed to somehow change that in the srt

@yanncoupin

This comment has been minimized.

Show comment Hide comment
@yanncoupin

yanncoupin Feb 8, 2012

You should probably specify the type of the parameter by adding type="int" and remove the inline conversion below

You should probably specify the type of the parameter by adding type="int" and remove the inline conversion below

@yanncoupin

This comment has been minimized.

Show comment Hide comment
@yanncoupin

yanncoupin Feb 8, 2012

Owner

You're applying an offset to the start of the file (for out of range subtitle suppression), but you're not applying that offset to the TCI & TCO timestamp which should also be transposed, just like the start timestamp.

Owner

yanncoupin commented Feb 8, 2012

You're applying an offset to the start of the file (for out of range subtitle suppression), but you're not applying that offset to the TCI & TCO timestamp which should also be transposed, just like the start timestamp.

@yanncoupin

This comment has been minimized.

Show comment Hide comment
@yanncoupin

yanncoupin Mar 5, 2012

Owner

Hey Patrick,

Can you make the changes I suggested so that I can merge you code?

Owner

yanncoupin commented Mar 5, 2012

Hey Patrick,

Can you make the changes I suggested so that I can merge you code?

@Naouak

This comment has been minimized.

Show comment Hide comment
@Naouak

Naouak Oct 8, 2012

Patrick, if you want, I have a repo with different tools that permit to edit STOL and there is an offset editor. It's all command line and it can automatically set tci to 0.

Naouak commented Oct 8, 2012

Patrick, if you want, I have a repo with different tools that permit to edit STOL and there is an offset editor. It's all command line and it can automatically set tci to 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment