Permalink
Branch: master
Find file Copy path
22d9a5e Feb 13, 2019
3 contributors

Users who have contributed to this file

@jaaberg @pReya @EvHaus
40 lines (30 sloc) 1.04 KB

Prevent using this.state within a this.setState (react/no-access-state-in-setstate)

This rule should prevent usage of this.state inside setState calls. Such usage of this.state might result in errors when two state calls are called in batch and thus referencing old state and not the current state. An example can be an increment function:

function increment() {
  this.setState({value: this.state.value + 1});
}

If these two setState operations is grouped together in a batch it will look be something like the following, given that value is 1:

setState({value: 1 + 1})
setState({value: 1 + 1})

This can be avoided with using callbacks which takes the previous state as first argument:

function increment() {
  this.setState(prevState => ({value: prevState.value + 1}));
}

Then react will call the argument with the correct and updated state, even when things happen in batches. And the example above will be something like:

setState({value: 1 + 1})
setState({value: 2 + 1})