Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraneous npm-check dependency in published package #1804

Closed
daltones opened this issue Jun 4, 2018 · 4 comments
Closed

Extraneous npm-check dependency in published package #1804

daltones opened this issue Jun 4, 2018 · 4 comments

Comments

@daltones
Copy link
Contributor

daltones commented Jun 4, 2018

I've just updated eslint-plugin-react from v7.8.2 to v7.9.0 and noticed a large change in my project's dependency tree.

That's because "npm-check": "5.7.1" appears as a dependency in the published package (although it isn't there in tag v7.9.0).

I certainly assume it shouldn't be there, right?

@ljharb
Copy link
Member

ljharb commented Jun 4, 2018

https://unpkg.com/eslint-plugin-react@7.9.0/package.json indeed it does.

@yannickcr did you perhaps npm install npm-check without --no-save or --save-dev before publishing?

@ljharb
Copy link
Member

ljharb commented Jun 4, 2018

I've published a v7.9.1, with updated deps, and the correct package.json.

@ljharb ljharb closed this as completed Jun 4, 2018
@yannickcr
Copy link
Member

yannickcr commented Jun 4, 2018

Oh, my mistake. I should have better checked the package.json before publishing.

Thanks for the quick fix @ljharb.

@ljharb
Copy link
Member

ljharb commented Jun 4, 2018

You may want to use npx npm-check rather than installing it in the future :-)

This was referenced Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants