Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-plugin-react@7.18.1 break eslint check #2561

Closed
im6 opened this issue Feb 1, 2020 · 8 comments
Closed

eslint-plugin-react@7.18.1 break eslint check #2561

im6 opened this issue Feb 1, 2020 · 8 comments
Labels

Comments

@im6
Copy link

@im6 im6 commented Feb 1, 2020

Hi, I just found v7.18.1 break my eslint check.
Below link there is error message, i revert the version back to 7.18.0 to fix my build.
https://github.com/im6/vp/actions
no sure if this only happen to me, but I tried cross multiple OS and both happening on NPM and Yarn.

Screen Shot 2020-02-01 at 6 21 22 PM

@ljharb
Copy link
Collaborator

@ljharb ljharb commented Feb 1, 2020

Thanks; any chance you know what code is causing the crash?

@im6
Copy link
Author

@im6 im6 commented Feb 1, 2020

@ljharb seems every time when there is null in my code, then eslint got break. I tried to replace null in my code with {}, then it works fine and passes.

@mjamado
Copy link

@mjamado mjamado commented Feb 2, 2020

I've found the same problem. It seems to me that everywhere there's a null, it crashes.

Replacing by undefined works, as well as something, but sometimes we really need the null there.

@jakeleventhal
Copy link

@jakeleventhal jakeleventhal commented Feb 2, 2020

Encountering the same issue

@igor-lemon
Copy link

@igor-lemon igor-lemon commented Feb 2, 2020

Found a temporary solution:
'react/jsx-indent': 0

@ljharb
Copy link
Collaborator

@ljharb ljharb commented Feb 2, 2020

cc @toshi-toma, from #2542.

I've got a fix ready; i'll publish a patch once tests pass.

@ljharb
Copy link
Collaborator

@ljharb ljharb commented Feb 2, 2020

v7.18.2 released.

@toshi-toma
Copy link
Contributor

@toshi-toma toshi-toma commented Feb 2, 2020

I'm very so sorry...
This bug is caused by my mistake.

@ljharb Thank you for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants