Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] `jsx-pascal-case`: false negative with namespacing #1337

Merged
merged 1 commit into from Jan 7, 2020

Conversation

@mfyuce
Copy link

mfyuce commented Jul 31, 2017

case #1334 - false negative with namespacing/qualifications using jsx-pascal

case #1336 - false postive with names starting with a number using jsx-pascal
[Can besaid it is fixed, but inside it is not accepted anyway. Seems just fixed the regex]

Fixes #1336.
@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Jul 31, 2017

#1336 is not an issue; identifiers can not start with numbers.

tests/lib/rules/jsx-pascal-case.js Outdated Show resolved Hide resolved
@yannickcr yannickcr force-pushed the yannickcr:master branch from f4737f0 to 73abadb Aug 9, 2017
@yannickcr yannickcr force-pushed the yannickcr:master branch from c8dedeb to dc9f85e Sep 24, 2017
@yannickcr yannickcr force-pushed the yannickcr:master branch from dca5cd5 to c148893 Nov 18, 2017
@ljharb ljharb force-pushed the mfyuce:master branch from b14d73c to f1041d2 Dec 30, 2019
@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Dec 30, 2019

@mfyuce any interest in completing this PR?

@ljharb
ljharb approved these changes Jan 7, 2020
@ljharb ljharb force-pushed the mfyuce:master branch from 54ce6ae to 5fac02c Jan 7, 2020
@ljharb ljharb changed the title case #1334 - case #1336 [Fix] `jsx-pascal-case`: false negative with namespacing Jan 7, 2020
@ljharb ljharb merged commit 5fac02c into yannickcr:master Jan 7, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 97.559%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.