Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full example in react/jsx-no-target-blank #1988

Merged
merged 3 commits into from Sep 20, 2018
Merged

Conversation

@atomcorp
Copy link
Contributor

atomcorp commented Sep 18, 2018

See #1986

I found the docs a bit unclear, so I've added a fuller example, hopefully in line with other examples.

@@ -18,6 +18,13 @@ There are two main options for the rule:
* `{"enforceDynamicLinks": "always"}` enforces the rule if the href is a dynamic link (default)
* `{"enforceDynamicLinks": "never"}` does not enforce the rule if the href is a dynamic link

```json
"react/jsx-no-target-blank": [<enabled>, { enforceDynamicLinks: <enforce> }]

This comment has been minimized.

Copy link
@ljharb

ljharb Sep 19, 2018

Collaborator

the key needs to be quoted, since it's json

This comment has been minimized.

Copy link
@atomcorp

atomcorp Sep 19, 2018

Author Contributor

added

docs/rules/jsx-no-target-blank.md Outdated Show resolved Hide resolved
```

* enabled: for enabling the rule. 0=off, 1=warn, 2=error. Defaults to 0.
* enforce: optional string, defaults to "always"

This comment has been minimized.

Copy link
@ljharb

ljharb Sep 19, 2018

Collaborator

this seems redundant, since it's on lines 18-19

This comment has been minimized.

Copy link
@atomcorp

atomcorp Sep 19, 2018

Author Contributor

Again, I'm following how it works on some other pages

@atomcorp

This comment has been minimized.

Copy link
Contributor Author

atomcorp commented Sep 19, 2018

Made that change. I looked at some of the other docs more carefully, and reordered the Rule Options so hopefully it makes a bit more sense.

@ljharb
ljharb approved these changes Sep 20, 2018
@ljharb ljharb merged commit eb69dc5 into yannickcr:master Sep 20, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.4%) to 96.443%
Details
@renovate renovate bot mentioned this pull request Dec 28, 2018
0 of 1 task complete
@renovate-bot renovate-bot mentioned this pull request Dec 28, 2018
0 of 1 task complete
This was referenced Dec 28, 2018
This was referenced Jan 4, 2019
@ibf-renovate ibf-renovate mentioned this pull request Jan 12, 2019
0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.