New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more friendly message for no-unescaped-entities #2016

Open
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@stevemao
Copy link
Contributor

stevemao commented Oct 13, 2018

No description provided.

@stevemao stevemao force-pushed the stevemao:feature/improve-escape-error branch from c0eb697 to f4dfffd Oct 14, 2018

@stevemao

This comment has been minimized.

Copy link
Contributor

stevemao commented Oct 14, 2018

BTW, why is & not in the default?

@stevemao

This comment has been minimized.

Copy link
Contributor

stevemao commented Dec 13, 2018

@ljharb Do you also want to change the option to be array of

{
  char,
  alternatives,
}

This would become a breaking change (change from array of strings)?

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Dec 15, 2018

I definitely want to avoid a breaking change.

@stevemao stevemao force-pushed the stevemao:feature/improve-escape-error branch 2 times, most recently from 97edfb0 to 9dde951 Dec 16, 2018

```

Where `char` is a special character and `alternatives` is the correct escapes.

This comment has been minimized.

@stevemao

stevemao Dec 16, 2018

Contributor

Also added docs

@stevemao stevemao force-pushed the stevemao:feature/improve-escape-error branch from 9dde951 to d806fc8 Dec 16, 2018

@ljharb

ljharb approved these changes Jan 3, 2019

@ljharb ljharb force-pushed the stevemao:feature/improve-escape-error branch from 6523eed to 76b6742 Jan 3, 2019

@ljharb ljharb added the enhancement label Jan 3, 2019

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Jan 3, 2019

(I'm going to hold off merging it for awhile while the 7.12 release settles down)

@ljharb ljharb requested review from EvHaus and yannickcr Jan 3, 2019

@EvHaus

EvHaus approved these changes Jan 4, 2019

Copy link
Collaborator

EvHaus left a comment

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment