Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`jsx-fragments`: improve message text #2032

Merged
merged 2 commits into from Dec 27, 2018

Conversation

@alexzherdev
Copy link
Contributor

alexzherdev commented Oct 31, 2018

No description provided.

@ljharb
ljharb approved these changes Oct 31, 2018
@@ -47,7 +47,8 @@ module.exports = {
if (!versionUtil.testReactVersion(context, '16.2.0')) {
context.report({
node,
message: 'Fragments are only supported starting from React v16.2'
message: 'Fragments are only supported starting from React v16.2. '
+ 'Please disable the `react/jsx-fragments` rule or upgrade your version of React.'

This comment has been minimized.

Copy link
@ljharb

ljharb Oct 31, 2018

Collaborator

maybe it’s worth adding “in eslint settings”?

@ljharb ljharb requested a review from EvHaus Oct 31, 2018
@alexzherdev

This comment has been minimized.

Copy link
Contributor Author

alexzherdev commented Oct 31, 2018

@ljharb our tests for ESLint 3 are broken due to eslint/typescript-eslint-parser#526 (when I fix typescript-eslint-parser to 20.0.0 they pass). Is this an example of peerDep changes being semver-major?

@alexzherdev alexzherdev force-pushed the alexzherdev:jsx-fragments-message branch from a5450cb to d6f7e1e Oct 31, 2018
@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Oct 31, 2018

Yes, technically that linked commit is a semver-major, and it'd be great if you filed an issue on that repo about it.

We'll have to peg to v20 of that dep in the meantime, then.

@EvHaus
EvHaus approved these changes Oct 31, 2018
Copy link
Collaborator

EvHaus left a comment

LGTM. Thanks for adding that in there.

@@ -39,7 +39,7 @@
"istanbul": "^0.4.5",
"mocha": "^5.2.0",
"typescript": "^3.1.3",
"typescript-eslint-parser": "^20.0.0"
"typescript-eslint-parser": "20.0.0"

This comment has been minimized.

Copy link
@ljharb

ljharb Oct 31, 2018

Collaborator

i think this is now fixed, so now we can use ^ again

This comment has been minimized.

Copy link
@alexzherdev

alexzherdev Oct 31, 2018

Author Contributor

Right, but should we say ^20.1.1 now?

This comment has been minimized.

Copy link
@ljharb

ljharb Oct 31, 2018

Collaborator

yes, good call

@alexzherdev alexzherdev force-pushed the alexzherdev:jsx-fragments-message branch from 58e3be7 to 5014b76 Nov 1, 2018
@ljharb ljharb force-pushed the alexzherdev:jsx-fragments-message branch from 5014b76 to 7d2eb6a Dec 27, 2018
@ljharb ljharb merged commit 7d07c37 into yannickcr:master Dec 27, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.449%
Details
@alexzherdev alexzherdev deleted the alexzherdev:jsx-fragments-message branch Dec 27, 2018
@renovate renovate bot mentioned this pull request Dec 28, 2018
0 of 1 task complete
@renovate-bot renovate-bot mentioned this pull request Dec 28, 2018
0 of 1 task complete
This was referenced Jan 4, 2019
@ibf-renovate ibf-renovate mentioned this pull request Jan 12, 2019
0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.