Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating no-target-blank logic to only require no-referrer #2043

Merged
merged 1 commit into from May 7, 2020

Conversation

@seancrater
Copy link
Contributor

@seancrater seancrater commented Nov 12, 2018

Fixes #2022

Just a minor change to only require no-referrer rather than both noreferrer noopener.

Copy link
Collaborator

@ljharb ljharb left a comment

Per discussion; it is in no way clear that this is an acceptable change to make.

See #2022 (comment).

@seancrater
Copy link
Contributor Author

@seancrater seancrater commented Nov 12, 2018

@ljharb Probably should've noted that I only made this so it's available if the team decides to go through with it.

@seancrater
Copy link
Contributor Author

@seancrater seancrater commented Nov 12, 2018

@ljharb Also shared what I found for research on the issue, I'm not sure if it's actually enough to draw a conclusion from but it seems like a pretty valid source to me.

@ljharb
Copy link
Collaborator

@ljharb ljharb commented May 7, 2020

Reopening per #2022 (comment)

@ljharb ljharb reopened this May 7, 2020
@ljharb ljharb force-pushed the seancrater:no-opener-no-referrer branch from 8e34d42 to f26789d May 7, 2020
@ljharb
Copy link
Collaborator

@ljharb ljharb commented May 7, 2020

Rebased this, and kept all existing test cases rather than modifying them.

@ljharb ljharb force-pushed the seancrater:no-opener-no-referrer branch 2 times, most recently from 6893aed to a8f648a May 7, 2020
@ljharb
ljharb approved these changes May 7, 2020
@ljharb ljharb force-pushed the seancrater:no-opener-no-referrer branch from a8f648a to b9d2eb5 May 7, 2020
@ljharb ljharb merged commit b9d2eb5 into yannickcr:master May 7, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.619%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants