New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link does not end with '.' #2103

Merged
merged 1 commit into from Jan 2, 2019

Conversation

2 participants
@yoyo837
Copy link
Contributor

yoyo837 commented Jan 2, 2019

Fix link hash #

@ljharb

ljharb approved these changes Jan 2, 2019

Copy link
Collaborator

ljharb left a comment

This seems fine, but what URL parser is having trouble with this?

@ljharb ljharb added the documentation label Jan 2, 2019

@yoyo837

This comment has been minimized.

Copy link
Contributor

yoyo837 commented Jan 2, 2019

It prints to the console, such as vscode , and can't scroll to the anchored location after clicking the link.

@ljharb ljharb merged commit 11a66c0 into yannickcr:master Jan 2, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.475%
Details

@yoyo837 yoyo837 deleted the yoyo837:patch-1 branch Jan 2, 2019

This was referenced Jan 2, 2019

This was referenced Jan 7, 2019

@ibf-renovate ibf-renovate referenced this pull request Jan 12, 2019

Open

Update linters #859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment