New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set state callback destructing & state use inside callback #2151

Merged
merged 1 commit into from Feb 2, 2019

Conversation

Projects
None yet
2 participants
@barakyosi
Copy link

barakyosi commented Feb 2, 2019

Fix no-unused-state rule:

  1. When using destruction in setState callback.
  2. When using state inside setState callback.

Fixes #1697

This is my first PR to open source :)

@ljharb
Copy link
Collaborator

ljharb left a comment

Thanks! Awesome start.

Show resolved Hide resolved lib/rules/no-unused-state.js

@ljharb ljharb added the bug label Feb 2, 2019

@ljharb

ljharb approved these changes Feb 2, 2019

@ljharb ljharb force-pushed the barakyosi:fix_no_unused_state branch from e8292fd to 4270205 Feb 2, 2019

@ljharb ljharb merged commit 4270205 into yannickcr:master Feb 2, 2019

3 of 5 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 97.513%
Details

@barakyosi barakyosi deleted the barakyosi:fix_no_unused_state branch Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment