Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsx-sort-default-props] Bug fix for one case with spread #2182

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
2 participants
@VincentLanglet
Copy link
Contributor

VincentLanglet commented Feb 28, 2019

Closes #2178

I thought an option was needed, but instead it was a bug

@VincentLanglet VincentLanglet changed the title Fix case with spread [jsx-sort-default-props] Bug fix for one case with spread Feb 28, 2019

@ljharb
Copy link
Collaborator

ljharb left a comment

Thanks, this looks great, pending one change :-)

Show resolved Hide resolved lib/rules/jsx-sort-default-props.js Outdated

@ljharb ljharb added the bug label Mar 7, 2019

@VincentLanglet

This comment has been minimized.

Copy link
Contributor Author

VincentLanglet commented Mar 7, 2019

@ljharb Done :)

@ljharb

ljharb approved these changes Mar 8, 2019

@ljharb ljharb force-pushed the VincentLanglet:fixSpread branch from 5620ec9 to cd0ca8d Mar 13, 2019

@ljharb ljharb merged commit cd0ca8d into yannickcr:master Mar 13, 2019

2 of 5 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.523%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.