Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] `display-name`: fix false negative around nested functions #2225

Merged
merged 1 commit into from Apr 3, 2019

Conversation

Projects
None yet
2 participants
@dwelle
Copy link
Contributor

dwelle commented Apr 3, 2019

Fixes #2221

RFC --- this is most likely not a good solution.

I've made sure that the component is marked only if the function node is the component itself.

@dwelle dwelle force-pushed the dwelle:display_name_nested branch from 4e362bc to 8b1a64f Apr 3, 2019

@ljharb

ljharb approved these changes Apr 3, 2019

Copy link
Collaborator

ljharb left a comment

fix and tests look good to me, thanks!

@ljharb ljharb added the bug label Apr 3, 2019

@ljharb ljharb merged commit 35de81b into yannickcr:master Apr 3, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 97.526%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.