Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update]`require-render-return`: more accurate report location #2229

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@golopot
Copy link
Contributor

golopot commented Apr 9, 2019

Previously the reported node is the whole component.
Now the reported node is the render method.

[Fix] `require-render-return`: more accurate report location
Previously the reported node is the whole component.
Now the reported node is the render method.

@ljharb ljharb force-pushed the golopot:require-render-return-report-node branch from 9495d7c to 5a60432 Apr 10, 2019

@ljharb

ljharb approved these changes Apr 10, 2019

Copy link
Collaborator

ljharb left a comment

Thanks!

@ljharb ljharb merged commit 5a60432 into yannickcr:master Apr 10, 2019

1 of 4 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.