Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] - Fix sorting props with numeric keys #2230

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
2 participants
@pawelnvk
Copy link
Contributor

pawelnvk commented Apr 9, 2019

Error occurs when some of props has keys declared as numbers. Object keys shouldn't be declared as numbers. Nevertheless, error should not occur.

Fixes #2212.

@ljharb

ljharb approved these changes Apr 9, 2019

Copy link
Collaborator

ljharb left a comment

Thanks!

Show resolved Hide resolved lib/rules/sort-prop-types.js Outdated

@ljharb ljharb added the bug label Apr 9, 2019

@ljharb ljharb force-pushed the pawelnvk:sorting-numeric-props branch from a860541 to b37a504 Apr 9, 2019

@ljharb ljharb merged commit b37a504 into yannickcr:master Apr 9, 2019

2 of 5 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 97.528%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.