Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolveSuperParameterPropsType): add null check #2232

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@jedwards1211
Copy link
Contributor

jedwards1211 commented Apr 10, 2019

fix #2179

@ljharb
Copy link
Collaborator

ljharb left a comment

Thanks, could you add a regression test?

@jedwards1211

This comment has been minimized.

Copy link
Contributor Author

jedwards1211 commented Apr 11, 2019

Yup, done

@jedwards1211

This comment has been minimized.

Copy link
Contributor Author

jedwards1211 commented Apr 11, 2019

@ljharb I'm confused by the CI failure, one node version failed with an error that doesn't seem related to my changes, yet an intermittent failure on this seems impossible:

 1) no-unused-prop-types
       valid
         class Hello extends Component {
  componentDidUpdate (prevProps) {
    if (prevProps.foo) {
      return true;
    }
  }
  render() {
    return (<div>{this.props.bar}</div>);
  }
}
Hello.propTypes = {
  foo: PropTypes.string,
  bar: PropTypes.string,
};:
      AssertionError: Should have no errors but had 1: [ { ruleId: null,
    fatal: true,
    severity: 2,
    message: 'Parsing error: Unexpected token {',
    line: 9,
    column: 18 } ]
      + expected - actual
      -1
      +0
      
      at testValidTemplate (node_modules\eslint\lib\testers\rule-tester.js:415:20)
      at Context.RuleTester.it (node_modules\eslint\lib\testers\rule-tester.js:584:25)
@ljharb

ljharb approved these changes Apr 12, 2019

@ljharb ljharb force-pushed the jedwards1211:patch-1 branch from ae88563 to 60b4b31 Apr 12, 2019

@ljharb ljharb merged commit 60b4b31 into yannickcr:master Apr 12, 2019

2 of 5 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.494%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.