Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement flow version detection #2233

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@jedwards1211
Copy link
Contributor

jedwards1211 commented Apr 10, 2019

not sure why you guys implemented React version detection without doing the same for Flow

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Apr 11, 2019

Looks good, but let’s add tests (just like react detection has)

@ljharb ljharb added the flow label Apr 11, 2019

@jedwards1211

This comment has been minimized.

Copy link
Contributor Author

jedwards1211 commented Apr 11, 2019

yup, done

@ljharb

ljharb approved these changes Apr 12, 2019

Copy link
Collaborator

ljharb left a comment

Thanks!

@ljharb ljharb force-pushed the jedwards1211:detect-flow-version-1 branch from 42dce6f to cc7b98b Apr 12, 2019

@ljharb ljharb merged commit cc7b98b into yannickcr:master Apr 12, 2019

2 of 5 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 97.512%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.