Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate boolean prop names nested deeper #2234

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@pawelnvk
Copy link
Contributor

pawelnvk commented Apr 10, 2019

Prop names nested inside of shape weren't validated. Issue shouldn't occur.

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Apr 11, 2019

This looks good, but I’m concerned about suddenly causing more warnings for people. Can we put this behind an option?

@pawelnvk

This comment has been minimized.

Copy link
Contributor Author

pawelnvk commented Apr 11, 2019

Ok. Now it should work with option.

@ljharb

ljharb approved these changes Apr 11, 2019

@ljharb ljharb added the enhancement label Apr 11, 2019

@ljharb ljharb force-pushed the pawelnvk:nested-prop-types branch from ad3d774 to 157332f Apr 12, 2019

@ljharb ljharb merged commit 157332f into yannickcr:master Apr 12, 2019

2 of 5 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 97.5%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.