Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] `no-render-return-value`: reuse version test result #2264

Merged
merged 2 commits into from May 6, 2019

Conversation

Projects
None yet
2 participants
@golopot
Copy link
Contributor

commented May 6, 2019

This commit likely fixes the performace issue noted in #2259.

golopot added some commits May 6, 2019

[Refactor] `no-render-return-value`: reuse version test result
This commit likely fixes the performace issue noted in #2259.
@ljharb

ljharb approved these changes May 6, 2019

Copy link
Collaborator

left a comment

Thanks, great improvement.

@ljharb ljharb force-pushed the golopot:refactor-no-render-return-value branch from 2fc4c80 to a7c48dd May 6, 2019

@ljharb ljharb merged commit a7c48dd into yannickcr:master May 6, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 97.454%
Details

@golopot golopot deleted the golopot:refactor-no-render-return-value branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.