Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make propTypes one word consistently #2271

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Make propTypes one word consistently #2271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16a3031
Make propTypes one word consistently
coryhouse May 12, 2019
81b6cdb
Update README.md
coryhouse May 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Expand Up @@ -128,7 +128,7 @@ Enable the rules that you would like to use.
* [react/no-unescaped-entities](docs/rules/no-unescaped-entities.md): Prevent invalid characters from appearing in markup
* [react/no-unknown-property](docs/rules/no-unknown-property.md): Prevent usage of unknown DOM property (fixable)
* [react/no-unsafe](docs/rules/no-unsafe.md): Prevent usage of unsafe lifecycle methods
* [react/no-unused-prop-types](docs/rules/no-unused-prop-types.md): Prevent definitions of unused prop types
* [react/no-unused-prop-types](docs/rules/no-unused-prop-types.md): Prevent definitions of unused propTypes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, now that I look at it, there's tons of usages of the phrase "prop types". propTypes is the property under which prop types are stored. I'm not sure there's anything to fix here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prop types isn't a term. It doesn't exist in React docs anywhere. I agree there are other pages that should be updated but I focused on this one.

I noticed this issue because I searched for propTypes to find rules related to it, but some had spaces so my search missed them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React docs aren't the sole authority of what is or is not a term; community usage trumps the official docs, and "prop types" is definitely a term that describes the concept of typing props.

* [react/no-unused-state](docs/rules/no-unused-state.md): Prevent definitions of unused state properties
* [react/no-will-update-set-state](docs/rules/no-will-update-set-state.md): Prevent usage of `setState` in `componentWillUpdate`
* [react/prefer-es6-class](docs/rules/prefer-es6-class.md): Enforce ES5 or ES6 class for React Components
Expand Down