Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make propTypes one word consistently #2271

Open
wants to merge 2 commits into
base: master
from
Open
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -128,7 +128,7 @@ Enable the rules that you would like to use.
* [react/no-unescaped-entities](docs/rules/no-unescaped-entities.md): Prevent invalid characters from appearing in markup
* [react/no-unknown-property](docs/rules/no-unknown-property.md): Prevent usage of unknown DOM property (fixable)
* [react/no-unsafe](docs/rules/no-unsafe.md): Prevent usage of unsafe lifecycle methods
* [react/no-unused-prop-types](docs/rules/no-unused-prop-types.md): Prevent definitions of unused prop types
* [react/no-unused-prop-types](docs/rules/no-unused-prop-types.md): Prevent definitions of unused propTypes

This comment has been minimized.

Copy link
@ljharb

ljharb May 12, 2019

Collaborator

Actually, now that I look at it, there's tons of usages of the phrase "prop types". propTypes is the property under which prop types are stored. I'm not sure there's anything to fix here.

This comment has been minimized.

Copy link
@coryhouse

coryhouse May 12, 2019

Author Contributor

Prop types isn't a term. It doesn't exist in React docs anywhere. I agree there are other pages that should be updated but I focused on this one.

I noticed this issue because I searched for propTypes to find rules related to it, but some had spaces so my search missed them.

This comment has been minimized.

Copy link
@ljharb

ljharb May 12, 2019

Collaborator

React docs aren't the sole authority of what is or is not a term; community usage trumps the official docs, and "prop types" is definitely a term that describes the concept of typing props.

* [react/no-unused-state](docs/rules/no-unused-state.md): Prevent definitions of unused state properties
* [react/no-will-update-set-state](docs/rules/no-will-update-set-state.md): Prevent usage of `setState` in `componentWillUpdate`
* [react/prefer-es6-class](docs/rules/prefer-es6-class.md): Enforce ES5 or ES6 class for React Components
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.