Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] make tests pass in eslint@6 #2304

Merged
merged 1 commit into from Jun 12, 2019

Conversation

Projects
None yet
3 participants
@golopot
Copy link
Contributor

commented Jun 10, 2019

Eslint 6.0.0-rc.0 is released 10 hours ago. This pr mostly fixes these two kinds of errors:

A fatal parsing error occurred: Parsing error: sourceType 'module' is not supported when ecmaVersion < 2015. Consider adding { ecmaVersion: 2015 } to the parser options.

Parsers provided as strings to RuleTester must be absolute paths.

@ljharb
Copy link
Collaborator

left a comment

Can we make eslint 6 explicitly tested in travis.yml, and not allowed to fail?

Also, can we fix appveyor too?

Show resolved Hide resolved tests/lib/rules/no-unused-prop-types.js Outdated
@golopot

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

Can we make eslint 6 explicitly tested in travis.yml, and not allowed to fail?

We cannot yet replace eslint@next with eslint@6 because the version eslint@6 does not exists. Maybe just wait until 6 is released?

$ npm i eslint@6
npm ERR! code ETARGET
npm ERR! notarget No matching version found for eslint@6
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

Also, can we fix appveyor too?

I believe appveyor just randomly fails. At least it passed in my fork. It seemed that the test fails when a downloaded package tarball is corrupted.

@ljharb

This comment has been minimized.

Copy link
Collaborator

commented Jun 11, 2019

@golopot true, but we can use @^6.0.0-0.

@golopot

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

Appveyor still fails at npm install.

Maybe this pr can wait until the release of eslint 6, which I think will be in 2 weeks.

@ljharb

ljharb approved these changes Jun 11, 2019

@petersendidit

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

I believe >6.0.0-rc would work for installing version 6 before its out of a prerelease version.

@ljharb

This comment has been minimized.

Copy link
Collaborator

commented Jun 11, 2019

@petersendidit yes, but then that would include v7 as well in the future. ^6.0.0-0 is the proper semver range.

@ljharb ljharb force-pushed the golopot:eslint-6 branch from d1280b3 to 3ae3a9a Jun 12, 2019

@ljharb ljharb merged commit 3ae3a9a into yannickcr:master Jun 12, 2019

2 of 5 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.585%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.