Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary schema from jsx-no-comment-textnodes #2340

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@bradzacher
Copy link

commented Jul 2, 2019

I noticed that there was a schema defining an empty object - it's an unnecessary definition, so remove it.

schema: [{
type: 'object',
properties: {},
additionalProperties: false

This comment has been minimized.

Copy link
@ljharb

ljharb Jul 3, 2019

Collaborator

this seems like it'd be a breaking change, in case someone had already been providing an empty object - also, the purpose of this schema is to make it easy for people to add new properties (without being forced to suddenly add the object)

This comment has been minimized.

Copy link
@bradzacher

bradzacher Jul 3, 2019

Author

as per #2341 - it's breaking in the strictest sense.

I personally don't see the point in keeping an invalid schema in here. Keeping it for the just in case seems a bit silly, considering that it has been waiting for just in case for 3 years?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.