Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary schema from require-render-return #2341

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@bradzacher
Copy link

commented Jul 2, 2019

I noticed that there was a schema defining an empty object - it's an unnecessary definition, so remove it.

@@ -21,7 +21,7 @@ module.exports = {
recommended: true,
url: docsUrl('require-render-return')
},
schema: [{}]
schema: []

This comment has been minimized.

Copy link
@ljharb

ljharb Jul 3, 2019

Collaborator

this seems like it'd be a breaking change, in case someone had already been providing an empty object.

This comment has been minimized.

Copy link
@bradzacher

bradzacher Jul 3, 2019

Author

it technically would be breaking in the strictest sense.
Though reviewing the history, this has been an empty object for 3 years, so I doubt there's some legacy config people have left over.

The problem is that this schema value doesn't just allow an empty object, it allows literally value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.