Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsx curly brace presence]: fix jsx tags in braces #2422

Conversation

@tanmoyopenroot
Copy link
Contributor

commented Sep 28, 2019

PR checklist

  • Addresses an existing issue: fixes #2416
  • bug
  • Includes tests
  • Documentation update

Overview of change:

Check for single JSXElement in child.

@ljharb
ljharb approved these changes Oct 1, 2019
@@ -96,7 +96,8 @@ ruleTester.run('jsx-curly-brace-presence', rule, {
options: [{props: 'never'}]
},
{
code: '<App>{<myApp></myApp>}</App>'
code: '<App>{<myApp></myApp>}</App>',

This comment has been minimized.

Copy link
@ljharb

ljharb Oct 1, 2019

Collaborator

this arguably is a breaking change :-/ hopefully we can consider this a patch though.

@ljharb ljharb force-pushed the tanmoyopenroot:2416-jsx-curly-brace-presence-fix-jsx-tags branch from fd09319 to 628a4a0 Oct 1, 2019
@ljharb ljharb merged commit 628a4a0 into yannickcr:master Oct 1, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.003%) to 97.567%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.