Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsx-curly-brace-presence): allow necessary white-space literal #2437

Merged
merged 2 commits into from Oct 3, 2019

Conversation

@uniqname
Copy link

commented Oct 2, 2019

Checks against use-case where white space literal is used to pad around JSX across newlines.

@ljharb
ljharb approved these changes Oct 3, 2019
@ljharb ljharb force-pushed the uniqname:fix/jsx-curly-brace-presence branch from d1ec25f to 4c89872 Oct 3, 2019
@ljharb ljharb force-pushed the uniqname:fix/jsx-curly-brace-presence branch from 4c89872 to 156e9f5 Oct 3, 2019
…` for back compat
@ljharb ljharb force-pushed the uniqname:fix/jsx-curly-brace-presence branch 3 times, most recently from 023be90 to 6f14e16 Oct 3, 2019
@ljharb ljharb merged commit 6f14e16 into yannickcr:master Oct 3, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 97.561%
Details
eventualbuddha added a commit to votingworks/bmd that referenced this pull request Oct 7, 2019
This was incorrectly removed by eslint-plugin-react v7.15.x due to a bug. It's been fixed in yannickcr/eslint-plugin-react#2437, so this commit updates eslint-plugin-react and re-adds the whitespace.
eventualbuddha added a commit to votingworks/bmd that referenced this pull request Oct 7, 2019
This was incorrectly removed by eslint-plugin-react v7.15.x due to a bug. It's been fixed in yannickcr/eslint-plugin-react#2437, so this commit updates eslint-plugin-react and re-adds the whitespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.