Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] `jsx-curly-brace-presence`: allow trailing spaces in literal #2448

Merged

Conversation

@doochik
Copy link
Contributor

doochik commented Oct 5, 2019

jsx-curly-brace-presence with never reports invalid errors in following cases

<Foo>{' space before or after '}</Foo>
<Foo>
  {'space after '}
  <a>link</a>
  {' space before'}
</Foo>
`jsx-curly-brace-presence` with `never` reports invalid errors in following cases

```
<Foo>{' space before or after '}</Foo>
```

```
<Foo>
  {'space after '}
  <a>link</a>
  {' space before'}
</Foo>
```
@doochik doochik force-pushed the doochik:jsx-curly-brace-presence_traling-spaces branch from 2ed84e3 to b25c239 Oct 5, 2019
@ljharb
ljharb approved these changes Oct 6, 2019
@ljharb ljharb force-pushed the doochik:jsx-curly-brace-presence_traling-spaces branch from b25c239 to 1436799 Oct 6, 2019
@ljharb ljharb merged commit 1436799 into yannickcr:master Oct 6, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0005%) to 97.552%
Details
@doochik doochik deleted the doochik:jsx-curly-brace-presence_traling-spaces branch Oct 7, 2019
@rpellerin

This comment has been minimized.

Copy link

rpellerin commented Oct 8, 2019

Do you know when this will be published please?

@ThiefMaster

This comment has been minimized.

Copy link
Contributor

ThiefMaster commented Nov 21, 2019

Yes, please make a release. I also encountered breakage in this JSX snippet where it tried to remove the curly braces (which is hopefully fixed by this PR as well):

                  <>
                    {', '}
                    <Translate>
                      <Param name="count" value={occurrenceCount} /> occurrences
                    </Translate>
                  </>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.