Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow explicit spread of props #2449

Merged
merged 1 commit into from Oct 8, 2019
Merged

Conversation

@pawelnvk
Copy link
Contributor

@pawelnvk pawelnvk commented Oct 5, 2019

PR to resolve: #2439

Copy link
Collaborator

@ljharb ljharb left a comment

This could use some examples in the docs.

docs/rules/jsx-props-no-spreading.md Outdated Show resolved Hide resolved
docs/rules/jsx-props-no-spreading.md Outdated Show resolved Hide resolved
docs/rules/jsx-props-no-spreading.md Outdated Show resolved Hide resolved
lib/rules/jsx-props-no-spreading.js Outdated Show resolved Hide resolved
lib/rules/jsx-props-no-spreading.js Outdated Show resolved Hide resolved
@pawelnvk
Copy link
Contributor Author

@pawelnvk pawelnvk commented Oct 8, 2019

@ljharb What do you think of prettier? Perhaps it could help us to keep consistent formatting across whole library.

@pawelnvk pawelnvk force-pushed the pawelnvk:2439-explicit-spread branch from a156ea3 to 5eba4fb Oct 8, 2019
@ljharb
ljharb approved these changes Oct 8, 2019
@ljharb ljharb force-pushed the pawelnvk:2439-explicit-spread branch from 5eba4fb to 0877bcd Oct 8, 2019
@ljharb ljharb merged commit 0877bcd into yannickcr:master Oct 8, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@ljharb
Copy link
Collaborator

@ljharb ljharb commented Oct 9, 2019

@pawelnvk no thanks; that’s what eslint is for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants