Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] `no-typos`: improve report location #2468

Merged
merged 1 commit into from Oct 29, 2019

Conversation

@golopot
Copy link
Contributor

golopot commented Oct 20, 2019

Previously the report location is property value. Now the report location is property key. This change is scoped to typos for propTypes, defaultProps, and ContextTypes.

class Zoo extends React.Component {
  static PROPTYPES = {};
//                   ~~   previous
//       ~~~~~~~~~        now
}

function Foo() {
  return <></>;
}

Foo.PROPTYPES = {};
//              ~~   previous
//  ~~~~~~~~~        now
@ljharb ljharb force-pushed the golopot:location-no-typos branch from 0f95b17 to 5be539b Oct 29, 2019
@ljharb
ljharb approved these changes Oct 29, 2019
@ljharb ljharb merged commit 5be539b into yannickcr:master Oct 29, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.007%) to 97.52%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.