Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint] enable eslint-plugin-eslint-plugin #2469

Merged
merged 1 commit into from Oct 29, 2019

Conversation

@golopot
Copy link
Contributor

golopot commented Oct 20, 2019

Most of the changes are deleting duplicate test cases.

@ljharb ljharb force-pushed the golopot:eslint-plugin-eslint-plugin branch from 97d7c2d to 51bb4be Oct 29, 2019
@ljharb
ljharb approved these changes Oct 29, 2019
Copy link
Collaborator

ljharb left a comment

i restored some of the test cases and added alternate parsers instead :-)

@ljharb ljharb force-pushed the golopot:eslint-plugin-eslint-plugin branch from 51bb4be to d9d2193 Oct 29, 2019
@ljharb ljharb merged commit d9d2193 into yannickcr:master Oct 29, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 97.524%
Details
@billyjanitsch

This comment has been minimized.

Copy link

billyjanitsch commented Dec 2, 2019

@ljharb shouldn't this have been added as a dev dependency, rather than as a dependency?

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Dec 2, 2019

yes, it should. thanks for the catch (#2510)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.