Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] jsx-sort-props: only use localeCompare when case is ignored #2556

Merged

Conversation

@tanmoyopenroot
Copy link
Contributor

@tanmoyopenroot tanmoyopenroot commented Jan 28, 2020

PR checklist

  • Addresses an existing issue: fixes #2381 #2530
  • bugfix
  • Includes tests
  • Documentation update

Overview of change:

remove the use of localCompare

Fixes #2381. Fixes #2530.

Co-authored-by: tanmoyopenroot <tanmoy.openroot@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@ljharb ljharb force-pushed the tanmoyopenroot:2530-fix-react/jsx-sort-props branch from be370a0 to 7e6bcdf May 12, 2020
@ljharb ljharb changed the title 2530: fix - react/jsx sort props [Fix] jsx-sort-props: only use localeCompare when case is ignored May 12, 2020
@ljharb ljharb force-pushed the tanmoyopenroot:2530-fix-react/jsx-sort-props branch from 7e6bcdf to f94d851 May 12, 2020
@ljharb
ljharb approved these changes May 12, 2020
@ljharb ljharb merged commit f94d851 into yannickcr:master May 12, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 97.604%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants