Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: remove ESLint v3 from dependencies #2562

Open
wants to merge 2 commits into
base: master
from

Conversation

@toshi-toma
Copy link
Contributor

toshi-toma commented Feb 2, 2020

already seems do not work in ESLint v3. and CI isn't checking ESLint v3.

errors 4245 passing (5s) 1 failing
  1. jsx-no-undef
    valid
    /eslint no-undef:1/ var React, App; React.render();:
    TypeError: Cannot read property 'variables' of null
    at checkIdentifierInJSX (lib/rules/jsx-no-undef.js:9:2040)
    at EventEmitter.JSXOpeningElement (lib/rules/jsx-no-undef.js:9:4242)
    at NodeEventGenerator.applySelector (node_modules/eslint/lib/util/node-event-generator.js:265:26)
    at NodeEventGenerator.applySelectors (node_modules/eslint/lib/util/node-event-generator.js:294:22)
    at NodeEventGenerator.enterNode (node_modules/eslint/lib/util/node-event-generator.js:308:14)
    at CodePathAnalyzer.enterNode (node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:602:23)
    at CommentEventGenerator.enterNode (node_modules/eslint/lib/util/comment-event-generator.js:98:23)
    at Traverser.enter (node_modules/eslint/lib/eslint.js:929:36)
    at Traverser.__execute (node_modules/estraverse/estraverse.js:330:31)
    at Traverser.traverse (node_modules/estraverse/estraverse.js:434:28)
    at Traverser.traverse (node_modules/eslint/lib/util/traverser.js:31:22)
    at EventEmitter.module.exports.api.verify (node_modules/eslint/lib/eslint.js:926:23)
    at runRuleForItem (node_modules/eslint/lib/testers/rule-tester.js:387:38)
    at testValidTemplate (node_modules/eslint/lib/testers/rule-tester.js:420:28)
    at Context. (node_modules/eslint/lib/testers/rule-tester.js:548:25)
    at processImmediate (internal/timers.js:439:21)
Copy link
Collaborator

ljharb left a comment

It’s still a breaking change - not a fix - to remove this from peer deps.

The proper fix is to resume testing on eslint 3, and fix any issues.

@ljharb ljharb added the semver-major label Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.