Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]jsx-indent: don't check literals not within JSX #2564

Merged
merged 1 commit into from Feb 3, 2020

Conversation

@toshi-toma
Copy link
Contributor

@toshi-toma toshi-toma commented Feb 3, 2020

Fixes #2563

@toshi-toma
Copy link
Contributor Author

@toshi-toma toshi-toma commented Feb 3, 2020

Anyway, I created PR.
I'll under investigation for other cases.

@toshi-toma toshi-toma force-pushed the toshi-toma:literals-not-within-jsx branch from 2beff81 to ed76296 Feb 3, 2020
@toshi-toma toshi-toma force-pushed the toshi-toma:literals-not-within-jsx branch from ed76296 to 72fd950 Feb 3, 2020
@toshi-toma
Copy link
Contributor Author

@toshi-toma toshi-toma commented Feb 3, 2020

I corresponded to JSXFragment. 2be9f24

@toshi-toma toshi-toma force-pushed the toshi-toma:literals-not-within-jsx branch from 72fd950 to 2be9f24 Feb 3, 2020
@toshi-toma
Copy link
Contributor Author

@toshi-toma toshi-toma commented Feb 3, 2020

I think it's fixed. Please review.🙏

@ljharb
ljharb approved these changes Feb 3, 2020
@ljharb
Copy link
Collaborator

@ljharb ljharb commented Feb 3, 2020

Thanks for the fast fix!

@ljharb ljharb force-pushed the toshi-toma:literals-not-within-jsx branch from 2be9f24 to 8b576be Feb 3, 2020
@ljharb ljharb merged commit 8b576be into yannickcr:master Feb 3, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0009%) to 97.582%
Details
@ljharb ljharb linked an issue that may be closed by this pull request Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants